bito-code-review[bot] commented on code in PR #42126:
URL: https://github.com/apache/superset/pull/42126#discussion_r3620141443
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Path/buildQuery.ts:
##########
@@ -32,7 +32,6 @@ export interface DeckPathFormData extends SqlaFormData {
line_type?: 'polyline' | 'json' | 'geohash';
metric?: string;
reverse_long_lat?: boolean;
- js_columns?: string[];
tooltip_contents?: unknown[];
Review Comment:
<!-- Bito Reply -->
The reviewer's observation is correct regarding the frontend removal, but
your reasoning for keeping the backend code is sound. Since existing saved
charts may still contain `js_columns` in their `form_data`, maintaining the
`BaseDeckGLViz.get_js_columns()` method and its associated tests ensures
backward compatibility for those legacy configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
