rusackas commented on PR #42126: URL: https://github.com/apache/superset/pull/42126#issuecomment-5026326382
Went through bito's last two "additional suggestions" batches since they're not tied to an actual review thread. The `common.tsx` onClick reordering doesn't change behavior, `table_filter` already took priority over `emitCrossFilters` in the original if/else chain. All this PR removed was the `js_onclick_href` branch that used to come first. The "legacy values" comment in `Path/transformProps.ts` is about `line_width` accepting either a number or a `FixedValue` shape, not the removed JS controls, so it's not orphaned. The `extraProps` fallback in `crossFiltersDataMask.ts` only existed to compensate for `js_columns` demoting matching properties into `extraProps`. Now that `js_columns` is gone (b83e0a8), that fallback was genuinely dead, not an inconsistency with Geojson's `properties` fallback, which is just standard GeoJSON feature structure and unrelated to `js_columns`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
