bito-code-review[bot] commented on code in PR #42126:
URL: https://github.com/apache/superset/pull/42126#discussion_r3619263183
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Path/buildQuery.ts:
##########
@@ -32,7 +32,6 @@ export interface DeckPathFormData extends SqlaFormData {
line_type?: 'polyline' | 'json' | 'geohash';
metric?: string;
reverse_long_lat?: boolean;
- js_columns?: string[];
tooltip_contents?: unknown[];
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Backend cleanup needed</b></div>
<div id="fix">
Frontend `js_columns` removal is correct per UPDATING.md (line 50: 'deck.gl
Extra data for JS control has also been removed'). However, the backend
`BaseDeckGLViz.get_js_columns()` (viz.py:2091) and its test
`test_get_js_columns` (viz_tests.py:916) remain orphaned - they will never
receive `js_columns` from this frontend path layer anymore.
</div>
</div>
<small><i>Code Review Run #d6d93e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
