bito-code-review[bot] commented on PR #44605:
URL: https://github.com/apache/superset/pull/44605#issuecomment-5812368238
<!-- Bito Reply -->
The flagged issue is incorrect. The code change in `superset/views/auth.py`
correctly overrides the `login` method to pass
`get_flashed_messages(with_categories=True)` into `render_app_template` as
`auth_messages`. This ensures that flash messages (including those from failed
login attempts) are correctly drained from the session and passed to the
frontend for rendering, maintaining compatibility with the existing
authentication flow.
No further action is required to resolve this specific issue.
**superset/views/auth.py**
```
return super().render_app_template(
{"auth_messages": get_flashed_messages(with_categories=True)}
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
