codeant-ai-for-open-source[bot] commented on code in PR #44605:
URL: https://github.com/apache/superset/pull/44605#discussion_r4092535335
##########
superset/views/auth.py:
##########
@@ -39,7 +39,14 @@ def login(self, provider: Optional[str] = None) ->
WerkzeugResponse:
if g.user is not None and g.user.is_authenticated:
return redirect(self.appbuilder.get_url_for_index)
- return super().render_app_template()
+ # Drain pending flash messages (failed logins, session
+ # invalidation, forced password change) so they render here
+ # instead of accumulating in the session. This must go through
+ # per-request extra_bootstrap_data, never the cached common
+ # bootstrap payload, so messages can't bleed between users.
+ return super().render_app_template(
+ {"auth_messages": get_flashed_messages(with_categories=True)}
+ )
Review Comment:
**Suggestion:** The override no longer delegates POST credentials or
provider names to Flask-AppBuilder, so password login and OAuth/SAML buttons
only render the login page instead of authenticating.
**Assessment:** ๐ด `Critical` ยท ๐ `Occurrence: Often` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4ab533ceaeb24aa78d8375bf03d14894&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4ab533ceaeb24aa78d8375bf03d14894&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/views/auth.py
**Line:** 47:49
**Comment:**
*Incomplete Implementation: The override no longer delegates POST
credentials or provider names to Flask-AppBuilder, so password login and
OAuth/SAML buttons only render the login page instead of authenticating.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44605&comment_hash=3ed3cb16d599cafeb2a5bbe4d5f125e18c041f14bad302b8362c5157473b2b89&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44605&comment_hash=3ed3cb16d599cafeb2a5bbe4d5f125e18c041f14bad302b8362c5157473b2b89&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
