rusackas commented on PR #44605: URL: https://github.com/apache/superset/pull/44605#issuecomment-5883751217
Nice fix for #44541, and solid test coverage on both ends. Codeant's `auth.py` thread looks like a false positive, bito already called that out. One small ask before this merges: could you add a test asserting the password field actually clears after an auth-failure toast? Copilot's right that only the toast dispatch is covered right now. Otherwise LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
