bito-code-review[bot] commented on code in PR #44605:
URL: https://github.com/apache/superset/pull/44605#discussion_r4092899285
##########
superset-frontend/src/pages/Login/Login.test.tsx:
##########
@@ -319,3 +331,79 @@ test('should use ensureAppRoot for all generated URLs with
deep application root
screen.getByRole('link', { name: /Sign in with Google/ }),
).toHaveAttribute('href', '/my-org/superset/login/google');
});
+
+// --- Auth flash messages ---
+
+test('should show flashed auth failures as danger toasts', () => {
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Misleading test name</b></div>
<div id="fix">
The test name says 'danger toasts', but it seeds a 'warning' flash and
asserts `mockAddWarningToast` was called while `mockAddDangerToast` was NOT
(lines 345-348). The name contradicts the assertions and will mislead
maintainers scanning test titles. Rename to reflect the warning-toast behavior.
</div>
</div>
<small><i>Code Review Run #8570df</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
