bito-code-review[bot] commented on code in PR #44605:
URL: https://github.com/apache/superset/pull/44605#discussion_r4131188849
##########
superset-frontend/src/pages/Login/Login.test.tsx:
##########
@@ -319,3 +331,79 @@ test('should use ensureAppRoot for all generated URLs with
deep application root
screen.getByRole('link', { name: /Sign in with Google/ }),
).toHaveAttribute('href', '/my-org/superset/login/google');
});
+
+// --- Auth flash messages ---
+
+test('should show flashed auth failures as danger toasts', () => {
Review Comment:
<!-- Bito Reply -->
The update to the test name is appropriate. Renaming the test to reflect the
warning-toast behavior correctly aligns the test title with the assertions,
ensuring clarity for future maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
