codeant-ai-for-open-source[bot] commented on code in PR #44685:
URL: https://github.com/apache/superset/pull/44685#discussion_r4110430681
##########
superset/db_engine_specs/oracle.py:
##########
@@ -45,6 +47,29 @@ class OracleEngineSpec(BaseEngineSpec):
max_column_name_length = 128
supports_multivalues_insert = True
+ # Oracle-native type names the base mappings don't cover. NUMBER is
Oracle's
+ # primary numeric type (reflected as e.g. "NUMBER" or "NUMBER(10, 2)"), and
+ # without these mappings such columns get no generic type, so they are not
+ # treated as numeric (no default SUM aggregate, excluded from numeric
+ # column lists). BLOB and RAW are binary and are intentionally left
unmapped.
+ column_type_mappings = (
+ (
+ re.compile(r"^number", re.IGNORECASE),
+ types.Numeric(),
+ GenericDataType.NUMERIC,
Review Comment:
**Suggestion:** The prefix-only pattern classifies unknown Oracle or
user-defined types such as `NUMBERING` as numeric, enabling incorrect
aggregation and filter handling.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incorrect condition
logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c915292cddca43a08c1ae97e3922fff1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c915292cddca43a08c1ae97e3922fff1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/db_engine_specs/oracle.py
**Line:** 57:59
**Comment:**
*Incorrect Condition Logic: The prefix-only pattern classifies unknown
Oracle or user-defined types such as `NUMBERING` as numeric, enabling incorrect
aggregation and filter handling.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44685&comment_hash=14d7b3f795f640bccac410e8dc0db034f7bf181c4984aff4c527f92e4222be46&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44685&comment_hash=14d7b3f795f640bccac410e8dc0db034f7bf181c4984aff4c527f92e4222be46&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
