aminghadersohi commented on code in PR #44685:
URL: https://github.com/apache/superset/pull/44685#discussion_r4129938715
##########
superset/db_engine_specs/oracle.py:
##########
@@ -45,6 +47,29 @@ class OracleEngineSpec(BaseEngineSpec):
max_column_name_length = 128
supports_multivalues_insert = True
+ # Oracle-native type names the base mappings don't cover. NUMBER is
Oracle's
+ # primary numeric type (reflected as e.g. "NUMBER" or "NUMBER(10, 2)"), and
+ # without these mappings such columns get no generic type, so they are not
+ # treated as numeric (no default SUM aggregate, excluded from numeric
+ # column lists). BLOB and RAW are binary and are intentionally left
unmapped.
+ column_type_mappings = (
+ (
+ re.compile(r"^number", re.IGNORECASE),
+ types.Numeric(),
+ GenericDataType.NUMERIC,
Review Comment:
Verified already fixed in 52581d133b23b80ed0b007a4495fb9d5b2be4439:
word-boundary patterns leave NUMBERING, BINARY_FLOATING, CLOBBER and NCLOBS
unmapped while NUMBER(10, 2) remains numeric. The regression cases pass after
the master merge (43 Oracle tests passed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
