aminghadersohi commented on code in PR #44685:
URL: https://github.com/apache/superset/pull/44685#discussion_r4113403905
##########
superset/db_engine_specs/oracle.py:
##########
@@ -45,6 +47,29 @@ class OracleEngineSpec(BaseEngineSpec):
max_column_name_length = 128
supports_multivalues_insert = True
+ # Oracle-native type names the base mappings don't cover. NUMBER is
Oracle's
+ # primary numeric type (reflected as e.g. "NUMBER" or "NUMBER(10, 2)"), and
+ # without these mappings such columns get no generic type, so they are not
+ # treated as numeric (no default SUM aggregate, excluded from numeric
+ # column lists). BLOB and RAW are binary and are intentionally left
unmapped.
+ column_type_mappings = (
+ (
+ re.compile(r"^number", re.IGNORECASE),
+ types.Numeric(),
+ GenericDataType.NUMERIC,
Review Comment:
Fixed in 52581d133b: the three patterns now end on a word boundary
(`^number\b`, `^binary_(float|double)\b`, `^n?clob\b`), so `NUMBER(10, 2)`
still maps but names like `NUMBERING` stay unmapped. Added test cases for those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
