aminghadersohi commented on PR #44685: URL: https://github.com/apache/superset/pull/44685#issuecomment-5884252053
Addressed both test-docstring suggestions in 6301433934: test_get_column_spec documents the Oracle-native and base mapping expectations; test_get_column_spec_unmapped_types (renamed from test_get_column_spec_binary_types_are_unmapped) documents intentionally unmapped binary types and unrelated prefix-sharing names. The NUMBERING prefix-match finding was already fixed in 52581d133b23b80ed0b007a4495fb9d5b2be4439 and verified with the regression tests. Merged origin/master in 52412cd1d2, preserving both the column mappings and the SQL Lab cancellation implementation/tests. Validation: all applicable pre-commit hooks passed, including ruff, mypy and pylint; the Oracle unit module passed all 43 tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
