bito-code-review[bot] commented on PR #44685:
URL: https://github.com/apache/superset/pull/44685#issuecomment-5843855970
<!-- Bito Reply -->
The flagged issue is correct. The current regex `re.compile(r"^number",
re.IGNORECASE)` matches any type starting with "number", which incorrectly
includes user-defined types like `NUMBERING` as numeric. To resolve this, the
regex should be updated to match only the exact `NUMBER` type, potentially
allowing for optional precision/scale parameters.
To fix this, update the regex in `superset/db_engine_specs/oracle.py` to
ensure it matches the full word `NUMBER`:
```python
(
re.compile(r"^number(\(\d+(,\s*\d+)?\))?$", re.IGNORECASE),
types.Numeric(),
GenericDataType.NUMERIC,
),
```
I have checked the PR comments and there are no other comments to address.
Would you like me to implement this fix for you?
**superset/db_engine_specs/oracle.py**
```
(
re.compile(r"^number(\(\d+(,\s*\d+)?\))?$", re.IGNORECASE),
types.Numeric(),
GenericDataType.NUMERIC,
),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
