aminghadersohi commented on PR #45531: URL: https://github.com/apache/superset/pull/45531#issuecomment-6303753053
Reviewed at a11378c772d4b9e61a5025199afef864417069dc. Holding approval on one item: fitzee's thread on get_compatible_metrics.py and get_compatible_dimensions.py. The new broad except turns AmbiguousDimensionError (documented as safe to show users) into a generic InternalError, while the REST /compatible endpoint still returns it as a 400 with the message. Handle it before the broad except and add a test for each tool. list_metrics.py still puts str(exc) in client-visible errors (lines 233 and 350); please fix it here or narrow the PR description. Both of fitzee's threads were posted after the last push, so they are still open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
