mikebridge commented on code in PR #45531: URL: https://github.com/apache/superset/pull/45531#discussion_r4353938868
########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -18355,6 +18355,12 @@ msgstr "Wert kann nicht dekodiert werden" msgid "Unable to encode value" msgstr "Wert kann nicht kodiert werden" +msgid "Unable to fetch semantic layer runtime schema." +msgstr "" + +msgid "Unable to fetch semantic view structure." +msgstr "" Review Comment: Thanks for checking this. An empty msgstr is an untranslated entry, so gettext falls back to the msgid rather than displaying a blank message ([GNU gettext documentation](https://www.gnu.org/software/gettext/manual/html_node/Translated-Entries.html)). I verified both strings against this German catalog with GNU msgfmt and Babel, including the Docker build’s use-fuzzy setting; both return the English text. Our catalog refresh deliberately uses --no-fuzzy-matching for new strings, so no catalog change is needed. ########## superset/mcp_service/semantic_layer/tool/list_metrics.py: ########## @@ -228,11 +229,16 @@ async def _collect_external_metrics( compatible_dimensions=compat_dims, ) ) - except Exception as exc: # noqa: BLE001 - # External registry may be empty in OSS — degrade gracefully + except AmbiguousDimensionError as exc: await ctx.warning( "Could not load metrics for view id=%s: %s" % (view.id, str(exc)) ) + except Exception: # noqa: BLE001 + # External registry may be empty in OSS — degrade gracefully + logger.warning( Review Comment: Could we keep the traceback here? Missing registration raises a plain KeyError, and provider failures have no shared unavailable exception at this boundary; catching those generic types could also hide metadata or implementation defects. An empty installation with no stored views never enters this handler, while a stored view whose provider is missing is configuration trouble worth diagnosing. AmbiguousDimensionError already takes a separate no-traceback path, and the remaining details stay in server logs while clients receive a fixed warning. The 38 focused tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
