mikebridge commented on PR #45531: URL: https://github.com/apache/superset/pull/45531#issuecomment-6305598986
@aminghadersohi, both items in [your hold comment](https://github.com/apache/superset/pull/45531#issuecomment-6303753053) are addressed: `7caa2a7ded` preserves `AmbiguousDimensionError` in both compatibility tools, and `a005ec089a` replaces unexpected `list_metrics` exception text with fixed client warnings/errors while retaining server diagnostics and safe host messages. Red-first tests cover both leak sites; the 240-test MCP gate and semantic-layer 100% coverage gate pass. This supersedes my earlier `list_metrics` deferral. One pre-existing, nonblocking follow-up remains: if a provider fails midway through a view, metrics already collected from that view remain alongside the warning. Could we decide separately whether discovery should be all-or-nothing per view? This fix preserves the existing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
