mikebridge commented on PR #45531: URL: https://github.com/apache/superset/pull/45531#issuecomment-6373789768
_AI-assisted reply on Mike's behalf._ @fitzee: good catch on the partial-results warning. 1909a70dfc adds the failed view's ID to the warning and still keeps provider text out. The regression failed in all four generic-error cases before the fix, and all 38 `list_metrics` tests pass afterward. I've also narrowed the title and summary so the PR doesn't imply that every metadata path or server log follows one policy. Still follow-ups, not changed here: - The datasource metadata handler in `superset/datasource/api.py`, and the bounded exception message in MCP `get_table`. Truncating a message there doesn't sanitize it. - The existing OAuth handling on `/structure` and `/schema/runtime`; this PR doesn't change its 422/400 behavior. - The existing mid-loop partial-view result behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
