sadpandajoe commented on code in PR #45696:
URL: https://github.com/apache/superset/pull/45696#discussion_r4369672468
##########
.github/workflows/superset-frontend.yml:
##########
@@ -109,7 +109,7 @@ jobs:
path: superset-frontend/coverage
report-coverage:
- needs: [sharded-jest-tests]
+ needs: [sharded-jest-tests] # This is required to configure all Jest tests
passed as required check in .asf.yaml
Review Comment:
Agreed—on this head Jest shard 2 failed and report-coverage was reported as
skipped, and GitHub treats a skipped required check as passing, so adding it to
the required contexts still lets a failing test merge. Should the job run under
if: always() and fail explicitly when any shard result is not success? Also,
its if reads needs.frontend-build, which isn't in its direct needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
