hainenber commented on code in PR #45696:
URL: https://github.com/apache/superset/pull/45696#discussion_r4369786819
##########
.github/workflows/superset-e2e.yml:
##########
@@ -505,10 +505,16 @@ jobs:
playwright-tests-required:
needs: [changes, playwright-tests]
if: always()
- runs-on: ubuntu-26.04
+ runs-on: ubuntu-slim
timeout-minutes: 5
- permissions: {}
+ permissions:
+ contents: read
+ actions: read
steps:
+ - uses:
Kesin11/actions-timeline@57fc93f20c6da7fbc14063c6d24a2a5627c799ad # v3.2.0
Review Comment:
This change is actually me trying to enforce the pattern similar to
[Python's `unit-tests-required`
check](https://github.com/apache/superset/blob/master/.github/workflows/superset-python-unittest.yml#L145-L172).
Would you be OK with this pattern?
Note that I exclude `frontend-tests-check` from this pattern as there are
other frontend-related jobs that should be non-required, i.e.
`validate-frontend` or `bundle-size`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
