hainenber commented on code in PR #45696:
URL: https://github.com/apache/superset/pull/45696#discussion_r4369679757
##########
.github/workflows/superset-frontend.yml:
##########
@@ -109,7 +109,7 @@ jobs:
path: superset-frontend/coverage
report-coverage:
- needs: [sharded-jest-tests]
+ needs: [sharded-jest-tests] # This is required to configure all Jest tests
passed as required check in .asf.yaml
Review Comment:
Agree on this review, good catch CodeAnt and Joe. I'll need to follow
existing patterns like `playwright-tests-required` and `unit-tests-required` job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
