sadpandajoe commented on code in PR #45696:
URL: https://github.com/apache/superset/pull/45696#discussion_r4369741605
##########
.github/workflows/superset-e2e.yml:
##########
@@ -505,10 +505,16 @@ jobs:
playwright-tests-required:
needs: [changes, playwright-tests]
if: always()
- runs-on: ubuntu-26.04
+ runs-on: ubuntu-slim
timeout-minutes: 5
- permissions: {}
+ permissions:
+ contents: read
+ actions: read
steps:
+ - uses:
Kesin11/actions-timeline@57fc93f20c6da7fbc14063c6d24a2a5627c799ad # v3.2.0
Review Comment:
Folding the timeline step into `playwright-tests-required` makes a
diagnostics action part of a required check, and it has no `continue-on-error`.
If the action hits a GitHub API error or outage, `playwright-tests-required`
goes red even when Playwright passed (or was legitimately skipped), and the PR
can't merge. The separate `actions-timeline` job wasn't required, so that
failure used to be harmless. This also isn't mentioned in the PR description.
Could the timeline stay in its own job, or at least get `continue-on-error:
true` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
