codeant-ai-for-open-source[bot] commented on code in PR #45696:
URL: https://github.com/apache/superset/pull/45696#discussion_r4369688096
##########
.github/workflows/superset-frontend.yml:
##########
@@ -109,7 +109,7 @@ jobs:
path: superset-frontend/coverage
report-coverage:
- needs: [sharded-jest-tests]
+ needs: [sharded-jest-tests] # This is required to configure all Jest tests
passed as required check in .asf.yaml
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `2661c84`.
The `frontend-tests-required` job now runs with `if: always()` and exits
with an error unless the sharded test result is `success` or `skipped`, so
failed or cancelled shards fail this required check.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
