sadpandajoe commented on code in PR #45649:
URL: https://github.com/apache/superset/pull/45649#discussion_r4419390284
##########
superset-frontend/src/pages/DatabaseList/index.tsx:
##########
@@ -1230,6 +1231,7 @@ function DatabaseList({
/>
<SemanticLayerModal
show={!!slCurrentlyEditing}
+ onUpdated={refreshData}
Review Comment:
If the Edit flow commits its PUT after Cancel, `DatabaseList` only gets the
Connections refresh from `onUpdated={refreshData}` here, and the page tests
cover that wiring only for create. Dropping this prop would leave the list
stale after a late edit without failing any test, because the modal test passes
its own callback. Could you add a `DatabaseList` test that opens Edit, defers
the PUT, cancels, waits for the cancel-triggered refresh, resolves the PUT, and
asserts a further Connections request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
