mikebridge commented on code in PR #45649:
URL: https://github.com/apache/superset/pull/45649#discussion_r4420637451
##########
superset-frontend/src/pages/DatabaseList/index.tsx:
##########
@@ -1230,6 +1231,7 @@ function DatabaseList({
/>
<SemanticLayerModal
show={!!slCurrentlyEditing}
+ onUpdated={refreshData}
Review Comment:
Added `a layer updated after Cancel refreshes the Connections list again` in
`DatabaseList.semanticLayerDelete.test.tsx`. It opens Edit, holds the PUT
pending, cancels, waits for the cancel-triggered Connections refresh, then
resolves the PUT and verifies a further Connections request. Removing
`onUpdated={refreshData}` makes the test fail at that final assertion; with the
callback restored, all 19 tests in the file pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
