villebro edited a comment on issue #9065: [sqla] Fixing ORDER BY logic URL: https://github.com/apache/incubator-superset/pull/9065#issuecomment-580999623 I wonder if we could instead ensure that the `.get_sqla_col()` methods in `TableColumn` and `SqlMetric` only instantiate each SqlAlchemy object once, and return the first instantiation upon subsequent calls. I believe this could be achieved by adding a `_sqla_col: Optional[Column]` attribute to said classes and return that if defined. This would save us from having to make the downstream code aware of this problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
