john-bodley commented on issue #9065: [sqla] Fixing ORDER BY logic URL: https://github.com/apache/incubator-superset/pull/9065#issuecomment-581061608 @villebro reading through the code I’m somewhat hesitant to add a class level corpus of columns to the `Table` class especially as this is scoped to the SQL query for a specific query context. An alternative would be to create a local corpus for each query however this would need to be passed around everywhere. We could make the SQL query it’s own class which stores the corpus, but I’m also concerned that we may be going down a rabbit hole.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
