villebro commented on issue #9065: [sqla] Fixing ORDER BY logic URL: https://github.com/apache/incubator-superset/pull/9065#issuecomment-581062140 @john_bodley agreed, major rabbit hole risk here, gives me flashbacks of `sqla/models.py` work in late 2018. I think we should do some more thorough refactoring + unit testing this time if we do decide to fix this more permanently. So perhaps just go ahead and merge this and defer the elegant solution to a later date.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
