villebro edited a comment on issue #9065: [sqla] Fixing ORDER BY logic
URL: 
https://github.com/apache/incubator-superset/pull/9065#issuecomment-581054986
 
 
   @john-bodley That's true; if the table id is included in the key this won't 
be a problem. I think if we have table id, column type (value of 
`sqla_col.is_literal` which is a proxy for groupable column or 
expression/metric), value (the value of `sqla_col.name`) and alias (the value 
of `label_expected`), I think we should be ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to