villebro commented on issue #9065: [sqla] Fixing ORDER BY logic URL: https://github.com/apache/incubator-superset/pull/9065#issuecomment-581010978 @john-bodley yes, that would be even DRYer. In addition to considering key column+label properties, I think memoization will probably need to include `db_engine_spec.engine` in the key to ensure engine specific behaviour doesn't leak.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
