john-bodley commented on issue #9065: [sqla] Fixing ORDER BY logic URL: https://github.com/apache/incubator-superset/pull/9065#issuecomment-581065275 @villebro agreed. The architecture of the sqla model should probably be refactored at some stage. Also there’s few few unit tests for the entire SQL generation, which we should address if we refactor, given how crucial this logic is.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
