john-bodley commented on a change in pull request #9366: deprecate groupby
controls in query_obj
URL:
https://github.com/apache/incubator-superset/pull/9366#discussion_r403094096
##########
File path: superset/connectors/druid/models.py
##########
@@ -1223,11 +1235,26 @@ def run_query( # druid
qry["granularity"] = "all"
qry["limit"] = row_limit
client.scan(**qry)
- elif len(groupby) == 0 and not having_filters:
+ elif (
+ IS_SIP_38
+ and columns
+ or not IS_SIP_38
+ and len(groupby) == 0
+ and not having_filters
+ ):
logger.info("Running timeseries query for no groupby values")
del qry["dimensions"]
client.timeseries(**qry)
- elif not having_filters and len(groupby) == 1 and order_desc:
+ elif (
+ IS_SIP_38
+ and not having_filters
+ and len(columns) == 1
+ and order_desc
+ or not IS_SIP_38
Review comment:
See ^^.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
