john-bodley commented on a change in pull request #9366: deprecate groupby
controls in query_obj
URL:
https://github.com/apache/incubator-superset/pull/9366#discussion_r403095046
##########
File path: superset/connectors/sqla/models.py
##########
@@ -749,7 +752,15 @@ def get_sqla_query( # sqla
"and is required by this type of chart"
)
)
- if not groupby and not metrics and not columns:
+ if (
+ IS_SIP_38
+ and not metrics
+ and not columns
+ or not IS_SIP_38
Review comment:
See ^^. Also if any of these conditions are the same a utility function may
be helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
