villebro commented on a change in pull request #9366: deprecate groupby
controls in query_obj
URL:
https://github.com/apache/incubator-superset/pull/9366#discussion_r407600889
##########
File path: superset/connectors/druid/models.py
##########
@@ -1188,7 +1189,12 @@ def run_query( # druid
)
# the dimensions list with dimensionSpecs expanded
- dimensions = self.get_dimensions(groupby, columns_dict)
+
+ if IS_SIP_38:
Review comment:
Thanks @john-bodley , I'll update the PR with these readability improvements
and merge once CI passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
