john-bodley commented on a change in pull request #9366: deprecate groupby
controls in query_obj
URL:
https://github.com/apache/incubator-superset/pull/9366#discussion_r403093355
##########
File path: superset/connectors/druid/models.py
##########
@@ -1213,7 +1219,13 @@ def run_query( # druid
order_direction = "descending" if order_desc else "ascending"
- if columns:
+ if (
+ IS_SIP_38
Review comment:
Do you think you should add parenthesis to ensure the `or` applied to
various blocks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
