michael-s-molina commented on a change in pull request #12010:
URL:
https://github.com/apache/incubator-superset/pull/12010#discussion_r541221006
##########
File path: superset-frontend/src/components/IconTooltip.tsx
##########
@@ -69,11 +74,11 @@ const Link = ({
mouseEnterDelay={0.3}
mouseLeaveDelay={0.15}
>
- {link}
+ {iconTooltip}
</Tooltip>
);
}
- return link;
+ return iconTooltip;
};
-export default Link;
+export default IconTooltip;
Review comment:
I also prefer named exports lol. I used default exports because of the
current code style but I think we can use the same approach as typescript and
use named exports for new components. Since this is a new component I'll make
the change =D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
