michael-s-molina commented on a change in pull request #12010:
URL:
https://github.com/apache/incubator-superset/pull/12010#discussion_r542312825
##########
File path: superset-frontend/src/SqlLab/components/QueryTable.jsx
##########
@@ -188,22 +188,22 @@ const QueryTable = props => {
);
q.actions = (
<div>
- <Link
- className="fa fa-pencil m-r-3"
+ <IconTooltip
+ className="fa fa-pencil m-r-3 pointer"
Review comment:
I was thinking... `IconTooltip` has a `className` property and a `style`
property. So I shouldn't add a `cursor` property because that is part of a
style. I could pass a property value of `style={{cursor: pointer}}` but since
I'm using `className` I think that passing the pointer class is better because
all the style of the component is being defined in a single place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
