rusackas commented on a change in pull request #12010:
URL:
https://github.com/apache/incubator-superset/pull/12010#discussion_r542598260
##########
File path: superset-frontend/src/SqlLab/components/QueryTable.jsx
##########
@@ -188,22 +188,22 @@ const QueryTable = props => {
);
q.actions = (
<div>
- <Link
- className="fa fa-pencil m-r-3"
+ <IconTooltip
+ className="fa fa-pencil m-r-3 pointer"
Review comment:
Totally agree that the `className` is better than the `style`! 100%
What I was suggesting (but not at all requiring!) was adding a `pointer`
prop to `IconTooltip`, i.e. `<IconTooltip pointer className=...>`
The IconTooltip would pass that prop into the `StyledSpan` you added, which
would then use it to render the styles needed, like so:
```
const StyledSpan = styled.span`
cursor: ${({ pointer }) => pointer ? 'pointer' : 'default'};
```
... but that may be overkill ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
