[GitHub] [superset] junlincc edited a comment on pull request #12903: fix(explore): hide time section for datasets with no time column

[GitBox]

junlincc edited a comment on pull request #12903:
URL: https://github.com/apache/superset/pull/12903#issuecomment-773681800


   Running a poll in slack #general, so far 11 responses, 100% agreed with 
hiding time section for datasets with no time column. 
   **81.8% It's confusing - I should only see a set of control that's relevant 
to my dataset and selected viz type.
   18.2% It's confusing - when I see an empty select dropdown in time column, I 
perceive it as a bug.**
   all answers came randomly from the community. 
   
   <img width="758" alt="Screen Shot 2021-02-04 at 3 40 39 PM" 
src="https://user-images.githubusercontent.com/67837651/106969361-893b7180-66ff-11eb-9d2a-c6682cfe2cd9.png";>
   
   This move is aligned with our long-term product vision in Explore.  It does 
seem risky in the short term, as automatic detection may not be able to catch 
columns correctly each time, but I would prefer to expose edge cases in early 
time.
   Also with the left data panel that lists all columns along with a data type 
icon, users can easily verify whether not seeing the time section is a bug or 
not. 
   
   <img width="637" alt="Screen Shot 2021-02-04 at 3 55 41 PM" 
src="https://user-images.githubusercontent.com/67837651/106970343-83df2680-6701-11eb-9e4e-c75dd6a29b42.png";>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org