a-cid opened a new pull request #13556: URL: https://github.com/apache/superset/pull/13556
### SUMMARY Athena API has a query size limit of 262144 bytes. Pandas `to_sql` will try to execute an INSERT INTO containing all records, which fails if the file is too large due to this limitation. The PyAthena DBAPI provides [helper methods](https://github.com/laughingman7743/PyAthena/#to-sql) that work around this limitation. This PR modifies Athena's db_engine_specs, adding an override to `create_table_from_csv` that defers to PyAthena's `to_csv` helper method when appropriate. ### TEST PLAN Try uploading CSV file larger than ~250kB ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
