bkyryliuk commented on a change in pull request #13556:
URL: https://github.com/apache/superset/pull/13556#discussion_r591792111
##########
File path: superset/db_engine_specs/athena.py
##########
@@ -64,3 +73,37 @@ def _mutate_label(label: str) -> str:
:return: Conditionally mutated label
"""
return label.lower()
+
+ @classmethod
+ def create_table_from_csv( # pylint: disable=too-many-arguments
Review comment:
it seems to me that a cleaner solution would be to move chunksize to the
config / make it per engine & set it to lower value for athena
https://github.com/apache/superset/blob/790ac5ef870815978f56ce81b806d43c18421940/superset/views/database/views.py#L193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
