Yicong-Huang commented on code in PR #7703:
URL: https://github.com/apache/texera/pull/7703#discussion_r3896067849
##########
.github/workflows/automatic-email-notif-on-ddl-change.yml:
##########
@@ -40,9 +40,13 @@ jobs:
FILE=$(git diff --name-only --diff-filter=A \
${{ github.event.pull_request.base.sha }} \
${{ github.event.pull_request.merge_commit_sha }} \
- -- 'sql/updates/')
+ -- 'sql/updates/*.sql')
echo "sql_file=$FILE" >> $GITHUB_OUTPUT
Review Comment:
Verified: line 47 now writes `sql_file=${FILE//$'\n'/, }`, so the value
stays one `key=value` line. Ran the step body verbatim under `bash -e` against
`7fbf64e3^..516087ed` (two migrations) — `sql_file=sql/updates/41.sql,
sql/updates/42.sql`, no bare line — and against `516087ed^..516087ed`, which
comes out byte-identical to before. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
