aglinxinyuan commented on PR #7703: URL: https://github.com/apache/texera/pull/7703#issuecomment-5482308372
Took it verbatim, `1fbd856`. You're right, and the problem was worse than a weak claim — it was unfalsifiable. `01` is the padded name, `23` needs no padding, and every live file is two digits anyway, so nothing in the tree can show whether the convention pads. One note in case you'd rather collapse it: the sentence immediately before already says #4401 "started the chain fresh at `23.sql`", so the replacement now states the restart twice in three lines. I applied your text as-is rather than editing a line you hadn't raised — say the word and I'll fold the two into one. Separately, this branch is rebuilt on current `main` (`bf03f8f`). The `build / pyamber (ubuntu-latest, 3.12)` failure on the previous run was not this PR: joblib 1.6.0 stopped vendoring cloudpickle, so `pip-licenses` began seeing it as its own distribution with no bullet in `amber/LICENSE-binary-python`, and every PR built after ~09:00 UTC went red on it. The 3.13 `Test with pytest` cancellation was fail-fast collateral. #8293 merged at 17:04 and the bullet is on `main`, so that job should come back green here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
