aglinxinyuan commented on PR #7703: URL: https://github.com/apache/texera/pull/7703#issuecomment-5481059632
Took the suggestion verbatim, `16aaa2c`. Fair catch, and the reason it matters is the one you gave: that comment is the only thing that will tell a future contributor why the pathspec is `*.sql` and not the directory, and it was describing every case except the one that forced it. For anyone reading the thread later, the four shapes a `ddl-change` PR can take without adding a migration: | shape | added under `sql/updates/` | mail | | --- | --- | --- | | adds a migration | `NN.sql` | sent, names the file(s) | | adds a non-`.sql` file | this PR's `README.md` | skipped | | edits or deletes only | nothing | skipped | | touches a `.sql` file elsewhere in the repo | nothing | skipped | Row 2 is this PR and the reason the guard exists; rows 3 and 4 were what the old comment described. One unrelated heads-up on this PR's CI, since it went red after your review and none of it is this PR: `build / pyamber (ubuntu-latest, 3.12)` fails repo-wide because joblib 1.6.0 stopped vendoring cloudpickle, so `pip-licenses` now sees it as its own distribution with no bullet in `amber/LICENSE-binary-python`. The 3.13 `Test with pytest` cancellation is fail-fast collateral from it. Fix is #8293; this branch needs a rebuild once that lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
