Yicong-Huang commented on code in PR #7703: URL: https://github.com/apache/texera/pull/7703#discussion_r3900030542
########## sql/updates/README.md: ########## @@ -0,0 +1,55 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. +--> + +# `sql/updates/` + +One file per schema migration. A file is live only when +[`sql/changelog.xml`](../changelog.xml) references it as a Liquibase +changeSet — the directory itself is never globbed for work to do, so an +unreferenced file here is inert. + +## The retired scripts, `01.sql`–`22.sql` + +They are not in the working tree; they are in git history. + +These 22 predate Liquibase. Operators applied them by hand, prompted by the +DDL-change notification e-mail. Liquibase arrived with +[#4401](https://github.com/apache/texera/pull/4401), which started the chain +fresh at `23.sql` and enrolled none of the 22 — so no runner in the repository +has been able to execute them since. They are also why the live files are +unpadded: the retired set is `01.sql`, the current set `23.sql`. Review Comment: Verified: `sql/updates/README.md:35-36` now reads "They are also why the live numbering starts at `23.sql` rather than `01.sql`", applied verbatim in `1fbd856`. Unlike the sentence it replaces, this one has a truth condition, and the tree satisfies it — `ls sql/updates/` is exactly `23.sql`–`42.sql` plus this README, and `sql/changelog.xml` references the same set. Resolving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
