Yicong-Huang commented on code in PR #7703:
URL: https://github.com/apache/texera/pull/7703#discussion_r3896060635
##########
.github/workflows/automatic-email-notif-on-ddl-change.yml:
##########
@@ -40,9 +40,13 @@ jobs:
FILE=$(git diff --name-only --diff-filter=A \
${{ github.event.pull_request.base.sha }} \
${{ github.event.pull_request.merge_commit_sha }} \
- -- 'sql/updates/')
+ -- 'sql/updates/*.sql')
echo "sql_file=$FILE" >> $GITHUB_OUTPUT
Review Comment:
Verified: `.github/workflows/automatic-email-notif-on-ddl-change.yml:47` now
writes `echo "sql_file=${FILE//$'\n'/, }" >> $GITHUB_OUTPUT`. I ran the step
body against the two commit pairs on `main` — `516087ed^`..`516087ed` gives
`sql_file=sql/updates/42.sql`, `7fbf64e3^`..`516087ed` gives
`sql_file=sql/updates/41.sql, sql/updates/42.sql` on one line, and both pass a
`key=value` check on every line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
