fishy commented on code in PR #3229:
URL: https://github.com/apache/thrift/pull/3229#discussion_r2494879626
##########
build/appveyor/MSVC-appveyor-full.bat:
##########
@@ -105,6 +105,7 @@ IF NOT "%QT_VERSION%" == "" (
CALL win_showenv.bat || EXIT /B
MKDIR "%WIN3P%" || EXIT /B
+@ECHO ON
Review Comment:
do we intend to leave this line in the code?
##########
lib/py/src/transport/TSSLSocket.py:
##########
@@ -47,8 +47,12 @@ class TSSLBase(object):
# SSL 2.0 and 3.0 are disabled via ssl.OP_NO_SSLv2 and ssl.OP_NO_SSLv3.
# For python < 2.7.9, use TLS 1.0 since TLSv1_X nor OP_NO_SSLvX is
# unavailable.
- _default_protocol = ssl.PROTOCOL_TLS_CLIENT if _has_ssl_context else \
- ssl.PROTOCOL_TLSv1
+ if sys.version_info < (3, 6):
+ _default_protocol = ssl.PROTOCOL_SSLv23 if _has_ssl_context else \
+ ssl.PROTOCOL_TLSv1
Review Comment:
I do wish appveyor can use an actual supported version of python 😞
can you link some doc indicating that on python <3.6 we can only use ssl
v2/v3 over tls? (similar to the ipv6 one below but in comment form)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
