CJCombrink commented on code in PR #3229:
URL: https://github.com/apache/thrift/pull/3229#discussion_r2497415287
##########
lib/py/src/transport/TSSLSocket.py:
##########
@@ -47,8 +47,12 @@ class TSSLBase(object):
# SSL 2.0 and 3.0 are disabled via ssl.OP_NO_SSLv2 and ssl.OP_NO_SSLv3.
# For python < 2.7.9, use TLS 1.0 since TLSv1_X nor OP_NO_SSLvX is
# unavailable.
- _default_protocol = ssl.PROTOCOL_TLS_CLIENT if _has_ssl_context else \
- ssl.PROTOCOL_TLSv1
+ if sys.version_info < (3, 6):
+ _default_protocol = ssl.PROTOCOL_SSLv23 if _has_ssl_context else \
+ ssl.PROTOCOL_TLSv1
Review Comment:
> I do wish appveyor can use an actual supported version of python 😞
Yes since there is no way to actually know if my changes now broken in newer
versions of Python. The github action only test the lib and does not run the
full test suite nor is python cross tested.
Would it make sense to try and add a new github action/pipeline for Windows
builds to replicate what is done in Appveyor or should one look at adding a new
Appveyor config? Not sure if there is a roadmap or task for something like
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
