CJCombrink commented on code in PR #3229:
URL: https://github.com/apache/thrift/pull/3229#discussion_r2500222651


##########
.github/workflows/build.yml:
##########
@@ -638,7 +638,7 @@ jobs:
 
       - uses: actions/setup-python@v6
         with:
-          python-version: "3.x"
+          python-version: "3.13"

Review Comment:
   _foreword: I am not a fan of squash commits especially on merge, it throws 
away a lot of history and the evolution of change. I have mentioned the reason 
in the commit so a blame will achieve the same. Yes no the same convenience but 
not so in-your-face when not interested, and can't drift when code is 
maintained._
   
   Yes will do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to