CJCombrink commented on code in PR #3229:
URL: https://github.com/apache/thrift/pull/3229#discussion_r2497544356
##########
lib/py/src/transport/TSSLSocket.py:
##########
@@ -47,8 +47,12 @@ class TSSLBase(object):
# SSL 2.0 and 3.0 are disabled via ssl.OP_NO_SSLv2 and ssl.OP_NO_SSLv3.
# For python < 2.7.9, use TLS 1.0 since TLSv1_X nor OP_NO_SSLvX is
# unavailable.
- _default_protocol = ssl.PROTOCOL_TLS_CLIENT if _has_ssl_context else \
- ssl.PROTOCOL_TLSv1
+ if sys.version_info < (3, 6):
+ _default_protocol = ssl.PROTOCOL_SSLv23 if _has_ssl_context else \
+ ssl.PROTOCOL_TLSv1
Review Comment:
Digging a bit (and not just trying to get the build green) I am lead to
believe that one would require Python 3.10 and OpenSSL 1.1.1 for the new TLS
support: https://docs.python.org/3/library/ssl.html and
https://docs.python.org/3.11/library/ssl.html#ssl.SSLContext
From the build output [OpenSSL
1.0.2u](https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/53025637/job/b08k6yr65ta2ugor?fullLog=true#L539)
is used.
I am not sure how to proceed here: Should I update my check to check for
3.10 instead and link to the ssl page?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
