CJCombrink commented on code in PR #3229:
URL: https://github.com/apache/thrift/pull/3229#discussion_r2497404169


##########
build/appveyor/MSVC-appveyor-full.bat:
##########
@@ -105,6 +105,7 @@ IF NOT "%QT_VERSION%" == "" (
 CALL win_showenv.bat || EXIT /B
 MKDIR "%WIN3P%" || EXIT /B
 
+@ECHO ON

Review Comment:
   I will remove it.
   I added it because for some reason the [`@ECHO 
ON`](https://github.com/apache/thrift/blob/master/build/appveyor/MSVC-appveyor-full.bat#L23)
  at the top of the page got disabled and I wanted to check why the 
[`DISABLED_TESTS`](https://github.com/apache/thrift/pull/3227/commits/bbc25217317980d78f3a577569b3c89ca3660875)
 did [not take 
affect](https://github.com/apache/thrift/pull/3227/commits/732553889f0d305b0550c812e88656334914aaab).
 Still no idea but not needed any more 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to